net: phy: marvell: Fix problem with phy_reset() clearing BMCR
authorStefan Roese <[email protected]>
Wed, 10 Feb 2016 06:06:06 +0000 (07:06 +0100)
committerJoe Hershberger <[email protected]>
Thu, 18 Feb 2016 17:32:03 +0000 (11:32 -0600)
commita8c3eca43393cffef16a40e683f7a4d45b37e6ed
treec43359163b153cf86d5e4d50f5655e9fd8bd5f52
parent3089c47ddc0ed7f5ca8a7aed9a6cddef5223cdf0
net: phy: marvell: Fix problem with phy_reset() clearing BMCR

With commit a058052c [net: phy: do not read configuration register on
reset], phy_reset() will clear the BMCR register. Resulting in bit 12
being cleared (A/N enable). This leads to autonegotiation link problems,
at least on the Marvell Armada ClearFog board. I suspect that other
boards using this driver will be affected as well.

At the of m88e1111s_config(), phy_reset() is called. This is not needed
for the PHY to load the changed configuration, as phy_reset() is called
a few lines before already. So lets call genphy_restart_aneg() here
instead to start the AN correctly.

Tested on clearfog.

Signed-off-by: Stefan Roese <[email protected]>
Cc: Stefan Agner <[email protected]>
Cc: Hao Zhang <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Andy Fleming <[email protected]>
Cc: Joe Hershberger <[email protected]>
Acked-by: Joe Hershberger <[email protected]>
drivers/net/phy/marvell.c